Repository navigation
Console: publish the page's text viewer as an adapter - #3029
Merged
HeikoKlare merged 1 commit intoOct 21, 2026
Merged
Conversation
The console page exposes its find/replace target and its text widget, but not the viewer that both of them come from. Clients that need to know where the console renders its text therefore have to ask for the widget, which describes how the text is presented rather than what presents it, and which leaves the viewer's document and selection handling out of reach. Answering ITextViewer closes that gap, and costs nothing: the console's viewer is a SourceViewer and therefore already an ITextViewer, so the page merely publishes what it has. The Find/Replace overlay, which places itself on the text viewer of the part it is opened in, can thereby be used in the console the same way as in a text editor. The existing Widget adapter stays in place for clients relying on it. Assisted-by: Claude Opus 5 <noreply@anthropic.com>
There was a problem hiding this comment.
🟢 Approval recommended
The narrow adapter addition exposes a compatible existing viewer without changing existing adapter behavior.
0 open findings
What changed in this PR
Exposes the console page’s existing text viewer to clients, enabling Console Find/Replace overlay integration alongside the companion UI change.
Changes:
- Adds an
ITextVieweradapter returning the existing viewer. - Preserves the existing find/replace target and widget adapters.
| File | Description |
|---|---|
| debug/org.eclipse.ui.console/src/org/eclipse/ui/console/TextConsolePage.java | Imports ITextViewer and handles adapter requests for it. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
HeikoKlare
marked this pull request as ready for review
October 19, 2026 10:08
r-mennig
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The console page exposes its find/replace target and its text widget, but not the viewer that both of them come from. Clients that need to know where the console renders its text therefore have to ask for the widget, which describes how the text is presented rather than what presents it, and which leaves the viewer's document and selection handling out of reach.
Answering
ITextViewercloses that gap, and costs nothing: the console's viewer is aSourceViewerand therefore already anITextViewer, so the page merely publishes what it has. The existingWidgetadapter stays in place for clients relying on it.Find/Replace overlay in the Console view
The Find/Replace overlay places itself on the text viewer of the part it is opened in, and
offers it in every part that exposes such a viewer. Neither change reaches the Console view on its own: this one adds an adapter that nothing asks for yet, and the other one finds no console to offer the overlay to. Together they bring the overlay to the Console view, where Ctrl+F then opens it instead of the Find/Replace dialog, with the same behavior it has in a text editor.
🤖 Generated with Claude Code