Repository navigation
Conversation
SWT rasterizes SVG icons with JSVG on the UI thread, and every feGaussianBlur is convolved again on each rasterization. In these 56 icons the blur changes no pixel by more than 20 of 255 at 100% and 200% zoom, so the filter costs time without any visible effect. Measured with JSVG 2.2.0 (median of 101 load and render runs), the median rasterization time per icon drops from 411 to 345 us at 100% and from 464 to 372 us at 200%, and rendering all 56 icons once drops from 30.6 to 24.5 ms at 100% and from 31.3 to 23.8 ms at 200%. The largest saving is debugts_obj, from 3.4 to 2.4 ms at 100%. Assisted-by: multiple AI agents and layers of automated tooling 🤖
Contributor
Author
|
Contributor
|
This pull request changes some projects for the first time in this development cycle. An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch. Git patchFurther information are available in Common Build Issues - Missing version increments. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SWT rasterizes SVG icons with JSVG on the UI thread, and every
feGaussianBluris convolved again on each rasterization. This removes the blur filter from 56 icons where it has no visible effect: rendered at 100% and 200% zoom, no pixel changes by more than 20 of 255. Most of them are frequently shown icons such as the Debug view thread, target and stack frame icons and the lock and clear actions of the Console, Terminal and JUnit views. Measured with JSVG 2.2.0, the median rasterization time per icon drops from 411 to 345 µs at 100% and from 464 to 372 µs at 200%, and rendering all 56 icons once drops from 30.6 to 24.5 ms at 100% and from 31.3 to 23.8 ms at 200% (largest single saving:debugts_obj, 3.4 to 2.4 ms). The 60 icons where the blur is visible, mostly wizard banners and a few glowing 16px icons, are left unchanged.