Show mouse move control even when not showing single line#2583
Merged
merks merged 1 commit intoeclipse-platform:masterfrom Mar 21, 2026
Merged
Show mouse move control even when not showing single line#2583merks merged 1 commit intoeclipse-platform:masterfrom
merks merged 1 commit intoeclipse-platform:masterfrom
Conversation
Contributor
Test Results 54 files ±0 54 suites ±0 35m 48s ⏱️ -56s For more details on these failures, see this check. Results for commit 0e395ed. ± Comparison against base commit 8f967b6. |
HannesWell
reviewed
Mar 21, 2026
Member
HannesWell
left a comment
There was a problem hiding this comment.
That's much better and looks good.
Thank you!
I tried this out and it mostly works well.
It's just that on long ranges the move buttons are hard to find without a marker.
On the other hand, showing a marker for short ranges looks like it clutters the diff.
Maybe the button marks (the small squares) can be shown only if a change exceeds a certain length.
However, this can also be done in a follow-up.
Contributor
Author
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


With this simple change, the controls to do the merging still appear when you hover over the area that's connecting the changes on the two sides:
@HannesWell @akurtakov
I think this addresses your concerns about lost of functionality.
@iloveeclipse
Given there is no visual appearance until you hover, I assume this is not a controversial addition.