Skip to content

Add Missing icons for Debug view launch context #2443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SougandhS wants to merge 1 commit into
base: master
Choose a base branch
from
+244 −3
Open

Add Missing icons for Debug view launch context #2443

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
113 changes: 113 additions & 0 deletions debug/org.eclipse.debug.ui/icons/full/obj16/add_to_fav.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
119 changes: 119 additions & 0 deletions debug/org.eclipse.debug.ui/icons/full/obj16/remove_from_fav.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 3 additions & 1 deletion debug/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/DebugPluginImages.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*******************************************************************************
* Copyright (c) 2000, 2025 IBM Corporation and others.
* Copyright (c) 2000, 2026 IBM Corporation and others.
*
* This program and the accompanying materials
* are made available under the terms of the Eclipse Public License 2.0
Expand Down Expand Up @@ -207,6 +207,8 @@ private static void declareImages() {
declareRegistryImage(IInternalDebugUIConstants.IMG_OBJS_LAUNCH_GROUP, OBJECT + "lgroup_obj.svg"); //$NON-NLS-1$
declareRegistryImage(IInternalDebugUIConstants.IMG_OBJS_CHECK, OBJECT + "check.svg"); //$NON-NLS-1$
declareRegistryImage(IInternalDebugUIConstants.IMG_OBJS_UNCHECK, OBJECT + "uncheck.svg"); //$NON-NLS-1$
declareRegistryImage(IInternalDebugUIConstants.IMG_OBJS_ADD_TO_FAV, OBJECT + "add_to_fav.svg"); //$NON-NLS-1$
declareRegistryImage(IInternalDebugUIConstants.IMG_OBJS_RMVE_FRM_FAV, OBJECT + "remove_from_fav.svg"); //$NON-NLS-1$

// tabs
declareRegistryImage(IInternalDebugUIConstants.IMG_OBJS_COMMON_TAB, OBJECT + "common_tab.svg"); //$NON-NLS-1$
Expand Down
4 changes: 3 additions & 1 deletion debug/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/IInternalDebugUIConstants.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*******************************************************************************
* Copyright (c) 2000, 2025 IBM Corporation and others.
* Copyright (c) 2000, 2026 IBM Corporation and others.
*
* This program and the accompanying materials
* are made available under the terms of the Eclipse Public License 2.0
Expand Down Expand Up @@ -134,6 +134,8 @@ public interface IInternalDebugUIConstants {
String IMG_OBJS_CHECK = "IMG_OBJS_CHECK"; //$NON-NLS-1$
String IMG_OBJS_UNCHECK = "IMG_OBJS_UNCHECK"; //$NON-NLS-1$
String IMG_OBJS_PROTO_TAB = "IMG_OBJS_PROTO_TAB"; //$NON-NLS-1$
String IMG_OBJS_ADD_TO_FAV = "IMG_OBJS_ADD_TO_FAV"; //$NON-NLS-1$
String IMG_OBJS_RMVE_FRM_FAV = "IMG_OBJS_RMVE_FRM_FAV"; //$NON-NLS-1$

// wizard images
String IMG_WIZBAN_IMPORT_BREAKPOINTS = "IMG_WIZBAN_IMPORT_BREAKPOINTS"; //$NON-NLS-1$
Expand Down
7 changes: 6 additions & 1 deletion ...g/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/actions/AddToFavoritesAction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*******************************************************************************
* Copyright (c) 2000, 2025 IBM Corporation and others.
* Copyright (c) 2000, 2026 IBM Corporation and others.
*
* This program and the accompanying materials
* are made available under the terms of the Eclipse Public License 2.0
Expand Down Expand Up @@ -29,6 +29,7 @@
import org.eclipse.debug.internal.core.IInternalDebugCoreConstants;
import org.eclipse.debug.internal.ui.DebugUIPlugin;
import org.eclipse.debug.internal.ui.IDebugHelpContextIds;
import org.eclipse.debug.internal.ui.IInternalDebugUIConstants;
import org.eclipse.debug.ui.DebugUITools;
import org.eclipse.debug.ui.IDebugUIConstants;
import org.eclipse.debug.ui.ILaunchGroup;
Expand Down Expand Up @@ -95,10 +96,14 @@ protected boolean updateSelection(IStructuredSelection selection) {
if (favoriteGroups.contains(group.getIdentifier())) {
setText(MessageFormat.format(ActionMessages.RemoveFromFavoritesAction,
fMode.substring(0, 1).toUpperCase() + fMode.substring(1)));
setImageDescriptor(
DebugUITools.getImageDescriptor(IInternalDebugUIConstants.IMG_OBJS_RMVE_FRM_FAV));
} else {
setText(MessageFormat.format(ActionMessages.AddToFavoritesAction_1,
DebugUIPlugin.removeAccelerators(
fMode.substring(0, 1).toUpperCase() + fMode.substring(1))));
setImageDescriptor(
DebugUITools.getImageDescriptor(IInternalDebugUIConstants.IMG_OBJS_ADD_TO_FAV));
}
} catch (CoreException e) {
DebugUIPlugin.log(e);
Expand Down
Loading