Skip to content

Find/Replace overlay: fix whole-word button enablement lagging by one keystroke #4165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HeikoKlare merged 1 commit into from
Jul 6, 2026
+13 −1
Merged

Find/Replace overlay: fix whole-word button enablement lagging by one keystroke #4165

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...nch.texteditor/src/org/eclipse/ui/internal/findandreplace/overlay/FindReplaceOverlay.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -701,8 +701,8 @@ private void createSearchBar() {
searchBar.forceFocus();
searchBar.selectAll();
searchBar.addModifyListener(e -> {
wholeWordSearchButton.setEnabled(findReplaceLogic.isAvailable(SearchOptions.WHOLE_WORD));
updateIncrementalSearch();
wholeWordSearchButton.setEnabled(findReplaceLogic.isAvailable(SearchOptions.WHOLE_WORD));
decorate();
});
searchBar.addFocusListener(new FocusListener() {
Expand Down
12 changes: 12 additions & 0 deletions ...itor.tests/src/org/eclipse/ui/internal/findandreplace/overlay/FindReplaceOverlayTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,18 @@ public void testSearchTermStoredInHistoryAfterSearchForward() {
assertEquals("foo", dialog.getFindText());
}

@Test
public void testWholeWordButtonEnabledStateImmediatelyReflectsCurrentSearchTerm() {
initializeTextViewerWithFindReplaceUI("foo bar foo");
OverlayAccess dialog= getDialog();

dialog.setFindText("foo ");
dialog.assertDisabled(SearchOptions.WHOLE_WORD);

dialog.setFindText("foo");
dialog.assertEnabled(SearchOptions.WHOLE_WORD);
}

@Test
public void testSearchTermStoredInHistoryAfterSearchBackward() {
// Backward search must persist the term to history just like forward search.
Expand Down
Loading