Remove beep from content assist when no proposals found#3781
Merged
vogella merged 1 commit intoeclipse-platform:masterfrom Mar 16, 2026
Merged
Remove beep from content assist when no proposals found#3781vogella merged 1 commit intoeclipse-platform:masterfrom
vogella merged 1 commit intoeclipse-platform:masterfrom
Conversation
The system beep fired every time content assist was manually invoked but had no proposals to show, which is disruptive and unhelpful.
Contributor
Author
|
This beep was driving me almost crazy during the work on #3779 |
Contributor
Author
|
@xpomul WDYT? Or do you think the beep is helpful? |
Contributor
Contributor
No, I don't think it's helpful. If at all, some small non-disturbing visual indicator (such as a 🚫 popup that is shown for a second or so, and maybe even deactivateable for advanced users) might be nice. But that is a separate enhancement IMO. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Display.beep()call inCompletionProposalPopup.hideWhenNoProposals()that fires every time content assist is manually invoked but has no proposals to showTest plan