Skip to content

Conversation

@vogella
Copy link
Contributor

@vogella vogella commented Jan 11, 2026

Migrate the ConformanceTestSuite and its dependent conformance test classes in org.eclipse.jface.tests.databinding to JUnit 5.
Verified with local tests.

@vogella vogella force-pushed the migrate-jface-databinding-conformance-junit5 branch from 34c11eb to 6b7b229 Compare January 11, 2026 14:35
@vogella vogella marked this pull request as draft January 11, 2026 14:35
@github-actions
Copy link
Contributor

github-actions bot commented Jan 11, 2026

Test Results

 2 511 files   -   513   2 511 suites   - 513   2h 20m 56s ⏱️ + 7m 30s
 7 160 tests  - 1 069   6 913 ✅  - 1 068  246 💤  - 2  1 ❌ +1 
20 304 runs   - 3 207  19 518 ✅  - 3 202  785 💤  - 6  1 ❌ +1 

For more details on these failures, see this check.

Results for commit d5a5ea1. ± Comparison against base commit e5503ef.

This pull request removes 1069 tests.
org.eclipse.core.tests.databinding.AggregateValidationStatusTest ‑ testAggregateValidationStatusValueType
org.eclipse.core.tests.databinding.AggregateValidationStatusTest ‑ testConstructor_DefaultRealm
org.eclipse.core.tests.databinding.BindingTest ‑ testDisposeBindingThenModel
org.eclipse.core.tests.databinding.BindingTest ‑ testDisposeBindingThenObservables
org.eclipse.core.tests.databinding.BindingTest ‑ testDisposeBindingThenTarget
org.eclipse.core.tests.databinding.BindingTest ‑ testDisposeModelDisposesBinding
org.eclipse.core.tests.databinding.BindingTest ‑ testDisposeModelThenBinding
org.eclipse.core.tests.databinding.BindingTest ‑ testDisposeObservablesThenBinding
org.eclipse.core.tests.databinding.BindingTest ‑ testDisposeTargetDisposesBinding
org.eclipse.core.tests.databinding.BindingTest ‑ testDisposeTargetThenBinding
…

♻️ This comment has been updated with latest results.

@vogella vogella force-pushed the migrate-jface-databinding-conformance-junit5 branch from 6b7b229 to a95e1d5 Compare January 12, 2026 09:03
@vogella vogella marked this pull request as ready for review January 12, 2026 09:03
@vogella vogella force-pushed the migrate-jface-databinding-conformance-junit5 branch 2 times, most recently from 996dc8e to 6d9d6ef Compare January 22, 2026 07:52
@akurtakov akurtakov force-pushed the migrate-jface-databinding-conformance-junit5 branch from 6d9d6ef to 1eaf6eb Compare January 25, 2026 10:51
- Migrate org.eclipse.jface.tests.databinding.conformance tests to JUnit 5.
- Update ConformanceTestSuite to use @testfactory.
- Update MANIFEST.MF to import junit.jupiter.api.function.
@akurtakov akurtakov force-pushed the migrate-jface-databinding-conformance-junit5 branch from 1eaf6eb to d5a5ea1 Compare January 28, 2026 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant