Test CTabItem rendering#3295
Conversation
basilevs
force-pushed
the
test_ctabfolder
branch
2 times, most recently
from
ce76b95 to
3ace3b9
Compare
| /* custom */ | ||
| protected CTabFolder ctabFolder; | ||
| private Color RED; | ||
| private Color BLUE; |
There was a problem hiding this comment.
It seems odd to use an all caps name for something that’s not a constant.
There was a problem hiding this comment.
Colors in SWT depend on Display, which I access via Shell, which is initialized after test starts. I could try to use Display.getCurrent() but this would be riskier (Display can be recreated). Therefore these are constants effectively but not in practice. Should I make them lowercase?
There was a problem hiding this comment.
Actually there are now Color constructors without a device and colors need not be disposed so they don’t really depend on a display/device.
When I see an all caps name, I expect it to static final, so yes, I’d prefer the name to match general expectations…
There was a problem hiding this comment.
I've made constants final using new constructors.
Test Results 196 files - 4 196 suites - 4 26m 58s ⏱️ +52s For more details on these failures, see this check. Results for commit ef91a4a. ± Comparison against base commit 6d13d81. ♻️ This comment has been updated with latest results. |
|
Windows CI is passing, Linux and MacOS are not. The test is passing on my MacOS. Configuration issue? The test seems trivial - it should work, as long as graphical context is available. How do I get screenshots? They are saved to |
basilevs
force-pushed
the
test_ctabfolder
branch
4 times, most recently
from
c710512 to
ee6a8f4
Compare
basilevs
force-pushed
the
test_ctabfolder
branch
3 times, most recently
from
6e429cb to
89518e1
Compare
akurtakov
force-pushed
the
test_ctabfolder
branch
from
89518e1 to
2697cd0
Compare
|
Would you please rebase on master ? |
|
Tests started to fail on Windows CI. They passed there on a previous rebase. Screenshots prove tabs are not rendered in 100ms. What am I doing wrong? 
Now: |
|
@HeikoKlare Windows regression might be related to recent pushes of GC redundancy fixes. Could you please run these tests with and without the changes? |
|
Windows has recovered. |
A regression test for eclipse-platform#3260 where tabs fail to render if `NSView.setClipsToBounds()` is omited before scheduling redraw. This test fails to reproduce the problem, but is useful as rendering is not tested at all in this suite.
akurtakov
force-pushed
the
test_ctabfolder
branch
from
16e32e8 to
ef91a4a
Compare
3 participants
Pixel color verification for CTabItem's tabs.
A regression test for #3260 where tabs fail to render if
NSView.setClipsToBounds()is omited before scheduling redraw.This test fails to reproduce the problem, but is useful as rendering is
not tested in this suite yet.