[Mac] Buttons with font sizes>23pt are not correctly rendered #3085#3086
Open
xpomul wants to merge 1 commit intoeclipse-platform:masterfrom
Open
[Mac] Buttons with font sizes>23pt are not correctly rendered #3085#3086xpomul wants to merge 1 commit intoeclipse-platform:masterfrom
xpomul wants to merge 1 commit intoeclipse-platform:masterfrom
Conversation
Contributor
xpomul
force-pushed
the
master
branch
2 times, most recently
from
6da9e14 to
8026642
Compare
…-platform#3085 Fix the issue by handling the case when a button uses a custom font with size > 16pt. In this case adjust the button height in cellSizeForBounds(), similar to the other height adjustment fixes already present. Signed-off-by: Stefan Winkler <stefan@winklerweb.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue #3085 by handling the case when a button uses a custom font with size > 16pt. In this case adjust the button height in cellSizeForBounds(), similar to the other height adjustment fixes already present.