[Win32] Prevent flickering of Link widget during resize #3016
+232
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vogella
force-pushed
the
link-flickering
branch
from
c3645d4 to
e24c484
Compare
The SysLink control in Windows has a tendency to flash or flicker when it is being resized. This happens because the background is erased before being redrawn by the control itself. This change overrides WM_ERASEBKGND for the Link widget to return LRESULT.ONE, which tells Windows that the background erasure has been handled. This prevents the unnecessary clear operation and results in a smoother resize experience without flickering. Also adding additional tests for the Link widgets for all platforms. Fixes eclipse-platform#1811
vogella
force-pushed
the
link-flickering
branch
from
e24c484 to
09940a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SysLink control in Windows has a tendency to flash or flicker when it is being resized.
This happens because the background is erased before being redrawn by the control itself.
This change overrides WM_ERASEBKGND for the Link widget to return LRESULT.ONE, which tells Windows that the background erasure has been handled.
This prevents the unnecessary clear operation and results in a smoother resize experience without flickering.
Also adding additional tests for the Link widgets for all platforms.
Fixes #1811