Skip to content

[Win32] Update JavaDoc in GC.setXORMode() regarding limitation with GDI+ #3006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ptziegler wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −0
Open

[Win32] Update JavaDoc in GC.setXORMode() regarding limitation with GDI+ #3006

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/GC.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5695,6 +5695,13 @@ private void setLineWidthInPixels(int lineWidth) {
* and the destination, and if the argument is <code>false</code>,
* puts the receiver in a drawing mode where the destination color
* is replaced with the source color value.
* <p>
* <b>IMPORTANT:</b> GDI+ has no direct support for raster
Copy link
Contributor

@HeikoKlare HeikoKlare Jan 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Javadoc of SWT API needs to be the same for every OS (as it is or at least can be consumed in an OS-agnostic way). So this extension needs to be applied to the GTK and Cocoa implementations of GC as well.
To make such a comment reasonable in an OS-agnostic way, it should start with an according statement, such as: "This operation may not work on every platform. Especially on Windows, GDI+ has no direct support [...]".

* operations (ROPs). This means that advanced graphics must be
* <b>disabled</b> when using XOR mode. More specifically, this
* means that all operations that require advanced mode (e.g.
* {@link Transform}) can't be used in combination with XOR mode.
* </p>
*
* @param xor if <code>true</code>, then <em>xor</em> mode is used, otherwise <em>source copy</em> mode is used
*
Expand Down
Loading