Skip to content

Ignore undefined all-zero alpha data for 32-bit icons without mask #2986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ShahzaibIbrahim wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −1
Open

Ignore undefined all-zero alpha data for 32-bit icons without mask #2986

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Image.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3142,12 +3142,14 @@ public ImageData getImageData() {
if (!hasMaskData && depth == 32) {
alphaData = new byte[width * height];
boolean hasAlphaData = false;
boolean isAllZeroAlpha = true;
for (int pixelIndex = 0; pixelIndex < alphaData.length; pixelIndex++) {
alphaData[pixelIndex] = data[pixelIndex * 4 + 3];
hasAlphaData |= alphaData[pixelIndex] != -1;
isAllZeroAlpha &= alphaData[pixelIndex] == 0;
}
// In case there is alpha data, replace the empty mask data with proper alpha data
if (hasAlphaData) {
if (hasAlphaData && !isAllZeroAlpha) {
maskData = null;
} else {
alphaData = null;
Expand Down
Loading