[GTK4] Clamp height of combo drop-down arrow to client area height #2818
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Test Results 146 files - 30 146 suites - 30 25m 16s ⏱️ - 3m 14s Results for commit d12bd6c. ± Comparison against base commit 8da42cd. This pull request removes 1 test.This pull request skips 1 test.♻️ This comment has been updated with latest results. |
jonahgraham
force-pushed
the
clamp-ccombo-height
branch
from
2cf802a to
d12bd6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2817
Note that this fix is needed for GTK4, but affects all platforms as it is in swt custom's CCombo. I am leaving this as draft for the moment because the preferred fix is probably fixing computeSizeInPixels of Button.