#1596: [Win32] Drawing produces unsymmetric results without swt.autoScale=false for 4k monitor with zooming#1607
Open
tmssngr wants to merge 2 commits into
Open
Conversation
Contributor
Test Results 382 files - 101 382 suites - 101 8m 8s ⏱️ -30s For more details on these failures, see this check. Results for commit bd0b255. ± Comparison against base commit 266cc26. This pull request removes 35 tests.This pull request skips 2 tests.♻️ This comment has been updated with latest results. |
06813ee to
bd0b255
Compare
added 2 commits
November 26, 2024 11:46
…ithout swt.autoScale=false for 4k monitor with zooming When drawing a vertical line at x == 1 with 200% zoom level (HiDPI), MacOS draws it on the physical pixel coordinates 2 and 3 while on Windows (with the existing code) it was drawn at 1 and 2. In other words: the existing code drew lines 1 pixel too far left/top. This commit should resolve this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When drawing a vertical line at x == 1 with 200% zoom level (HiDPI),
MacOS draws it on the physical pixel coordinates 2 and 3 while on
Windows (with the existing code) it was drawn at 1 and 2.
In other words: the existing code drew lines 1 pixel too far left/top.
This commit should resolve this.