-
Notifications
You must be signed in to change notification settings - Fork 60
Allow stepping through disassembly #831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Thanks for the feature @danthe1st, looks great on feature wise Would it be possible to change highlight color for dark theme ? its bit hard to read
|
|
This pull request changes some projects for the first time in this development cycle. An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch. Git patchFurther information are available in Common Build Issues - Missing version increments. |
a53115b to
191da85
Compare
|
@SougandhS I updated this to use the current instruction pointer background color (see the updated screenshots). Do you know whether there is a way to detect when the stack current stack frame is no longer there/when the highlighting should be removed (e.g. when resuming or stepping into a different file)? |
Thanks, much better now
You can achieve this by registering an |
86a12ff to
86d25a3
Compare
86d25a3 to
5935fe2
Compare
|
@SougandhS Hi. Now that I was able to write a test for this as well, I think eclipse-jdt/eclipse.jdt.ui#2708 and this are ready for review. Note that this won't be able to build successfully without eclipse-jdt/eclipse.jdt.ui#2708. |

What it does
This PR allows stepping through the bytecode of disassembled classes in the class file editor.
This is just an unfinished prototype but I wanted to create a (draft) PR early to be able to get feedback and show the basic approach.
This depends on another PR in jdt.ui (eclipse-jdt/eclipse.jdt.ui#2708)
@SougandhS Since you have worked on similar things recently, I think you might be interested in that.
TODO
How to test
Author checklist