[3] Do not disable scrollable widgets when not editable#5
Conversation
Not editable widget must not be disabled. Disable widget cannot be scrolled. User should be able to read and copy the content. Actions must still be driven by "is Enabled Expression". eclipse-eef#3 Change-Id: I46b47a1ade5b3472191e619f07aa1c4db93adaa9 Signed-off-by: Nicolas Peransin <nicolas.peransin@obeo.fr>
61b76b3 to
7b89c5d
Compare
| h4. Specifier-Visible Changes | ||
|
|
||
| * <span class="label label-info">Modified</span> The dynamic mappings will take into account all the "if" blocks with a valid predicate expression and not only the first one. | ||
| * <span class="label label-info">Modified</span> The dynamic mappings will take into account all the «if» blocks with a valid predicate expression and not only the first one. |
There was a problem hiding this comment.
Is this change voluntary? Not sure it is "safe" in terms of potential encoding issues.
There was a problem hiding this comment.
in version version, Textile-to-html in mylyn was changing " into «. (at least into the html code « )
But last version (at least 2025/09) does not do it any more.
However most browser render '«' directly now.
So to keep the same text for user, I changed the textile text.
lredor
left a comment
There was a problem hiding this comment.
Minor change expected (expected behavior is OK)
|
|
||
| h3(#eef2.1.7). Changes in EEF 2.1.7 | ||
|
|
||
| * <span class="label label-info">Modified</span> When disabled, content of lists, text areas and field are still readable. Widgets are scrollable and selectable even if they cannot be edited and actions are disabled. |
There was a problem hiding this comment.
Proposition: When disabled, the content of lists, text areas, and text fields remains readable. Widgets can still be scrolled and text can be selected, even though editing is disabled and actions are unavailable.
Not editable widget must not be disabled.
Disable widget cannot be scrolled.
User should be able to read and copy the content.
Actions must still be driven by "is Enabled Expression".
#3
How to test
Create a modeling Project with following VSM et Ecore model sample:
test_resources.zip
Select a EClass from Model explorer.
Some widgets are read-only state.
Expected: read-only texts and lists can be scrollable.
Expected: no popup dialog when selecting item of read-only lists but a dialog popup when selecting item of editable lists
Expected: read-only widgets have a different background from editable widgets.