Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -266,10 +266,9 @@ public StringBuilder generateOrderByNulls(CharSequence expr, boolean ascending,
return generateOrderByNullsAnsi(expr, ascending, collateNullsLast);
}

@Override
public boolean allowsJoinOn() {
return false;
}
// No allowsJoinOn override: Oracle reads ANSI JOIN ... ON since 9i. The false it returned was an inherited
// base-class default rather than a reason of Oracle's, and Oracle alone wrote comma joins with the join
// condition in WHERE (database run 19./20.10., the drill-through statements; F-10.6 5a).

@Override
public boolean allowsRegularExpressionInWhereClause() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,12 @@ public void setUp() throws Exception {
dialect = new OracleDialect(org.eclipse.daanse.sql.dialect.api.DialectInitData.fromConnection(connection));
}

/** Oracle reads ANSI joins; comma joins were the inherited default, not an Oracle limit. */
@Test
void anInnerJoinIsWrittenWithJoinOn() {
assertTrue(dialect.allowsJoinOn());
}

@Test
void testAllowsRegularExpressionInWhereClause() {
assertTrue(dialect.allowsRegularExpressionInWhereClause());
Expand Down
Loading