Repository navigation
fix(dialect): the n-th value is an aggregate over the group's rows - #67
Merged
Merged
Conversation
NTH_VALUE ran as a window over the groups and showed other members' values. Dialects without an ordered array aggregate refuse the measure. Signed-off-by: Stefan Bischof <stbischof@bipolis.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NTH_VALUE(col, n) OVER (ORDER BY ...)in a grouped query runs over the groups, not over the rows of each group, so a cell showed the values of other members.ARRAY_AGG; nulls are filtered when asked.DuckDbNthValueTest.Note: the tutorial check suite
measure.aggregator.nthin rolap.mapping still expects the old window values.