Repository navigation
harden(guard): block side-effecting selects and document the contract - #50
Merged
Merged
Conversation
Build on the data-modifying-CTE fix already on main. Extend SqlGuard's read-only enforcement to the rest of the "parses as Select but has a side effect" class, and document the contract: - reject SELECT ... INTO (writes a table) and FOR UPDATE/FOR SHARE (locks); - fail closed: any unexpected RuntimeException during validation now becomes a GuardException instead of propagating or passing through; - add javadoc to SqlGuard.guard()/SqlGuardFactory.create() and a guard/README.md covering the read-only contract and the function whitelist (full-match case-sensitive regex, empty = deny-all). Extends ReadOnlyStatementValidator and adds integration tests for each new case. Signed-off-by: Stefan Bischof <stbischof@bipolis.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build on the data-modifying-CTE fix already on main. Extend SqlGuard's read-only enforcement to the rest of the "parses as Select but has a side effect" class, and document the contract:
Extends ReadOnlyStatementValidator and adds integration tests for each new case.