Improved MSVC detection fixes #929

[azuo]

No description provided.

[jonahgraham]

@azuo This PR got neglected as there seems to be none of the active committers in Eclipse CDT that know about this issue.

I think this is probably correct based on the vswhere documentation about finding a VC installation here https://github.com/microsoft/vswhere/wiki/Find-VC#batch

This may be eligible under #1347 - but I think it needs at least some manual testing first since there are no automated tests in this area.

cc: @MarkZ3 as the author of detectVSInstallation in case he still knows about this and can comment.

[MarkZ3]

I tested it with my VS2022 environment and it works. So it's fine by me to merge. Thanks!

[github-actions]

Test Results

  585 files  ±0    585 suites  ±0   13m 40s ⏱️ -6s
9 917 tests ±0  9 893 ✅ ±0  24 💤 ±0  0 ❌ ±0 
9 955 runs  ±0  9 931 ✅ ±0  24 💤 ±0  0 ❌ ±0 

Results for commit a55de3c. ± Comparison against base commit 6574af3.

[jonahgraham]

Thank you @azuo for the contribution - and apologies for the long delay. Thank you @MarkZ3 for reviewing.