Fix: Handle XSD end-of-day midnight notation 24:00:00#582
Open
paul-gerber-svg wants to merge 2 commits into
Open
Fix: Handle XSD end-of-day midnight notation 24:00:00#582paul-gerber-svg wants to merge 2 commits into
paul-gerber-svg wants to merge 2 commits into
Conversation
Before, parsing XSD timestamps with an hour of 24 causes a ValueError. Now, the parser in `sdk/basyx/aas/model/datatypes.py` correctly identifies 24:00:00 as midnight, handles the day rollover for `DateTime`, and normalizes `Time` to 00:00:00. Unit tests for valid and invalid edge cases are added to `sdk/test/model/test_datatypes.py` inside `TestDateTimeTypes`. Fixes eclipse-basyx#564
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, parsing XSD timestamps with an hour of 24 causes a ValueError. Now, the parser in
sdk/basyx/aas/model/datatypes.pycorrectly identifies 24:00:00 as midnight, handles the day rollover forDateTime, and normalizesTimeto 00:00:00.Unit tests for valid and invalid edge cases are added to
sdk/test/model/test_datatypes.pyinsideTestDateTimeTypes.Fixes #564