Merged
Conversation
bar. Reparented to EDL develop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and fixes across the EasyReflectometry application, focusing on experiment loading, model/parameter handling, fitting result reporting, and user interface enhancements. The most notable changes include automatic synchronization of q-range limits when loading experiments, improved calculation and reporting of fit statistics, and UI updates to better reflect application state and actions.
Key changes:
Experiment and Model Handling
q_maxvalue with the largest q value from loaded experiments. This ensures that model limits reflect the data and emits a newqRangeUpdatedsignal when the q-range changes. This affects how experiments are loaded and signals are propagated throughout the application.Modelsclass to fetch models dynamically from the project library, ensuring the model list is always up-to-date.Fitting Results and Parameter Display
fit_n_parsnow reports the global number of refined parameters (not a sum), andfit_chi2now returns the reduced chi-squared (chi2 per degree of freedom) for multi-fit scenarios, providing more accurate and meaningful fit quality metrics.User Interface and Signal Connections
Maintenance and Copyright
These changes collectively improve data integrity, result reporting, and the responsiveness of the user interface to changes in the application's state.