Repository navigation
fix: restore main tests and coverage collection - #5
Merged
Merged
Conversation
loong10k
marked this pull request as ready for review
November 4, 2026 00:04
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
main cannot compile its 110 test sources because test dependencies are absent, and Surefire overwrites the JaCoCo agent arguments. Add test-scoped Jupiter, Spring Test, Mockito and matching Reactor Test dependencies; preserve late JaCoCo arguments and reject zero-test runs. CI now requires test and coverage reports after clean verify.
Validation: JDK 17 clean verify ran all 110 suites / 505 tests with zero failures, errors or skips. JaCoCo recorded 1,161 / 1,456 covered lines (79.74%); the existing 90% warning threshold and haltOnFailure=false remain unchanged. No production source or public API changed, including MySessionRegistryImpl.
This fixes the upstream test build only; it does not establish spring-security-jwt Spring 5/6 or javax/Jakarta runtime compatibility.