Repository navigation
fix: collect real coverage for Shiro and pinned JWT tests - #4
Merged
Merged
Conversation
loong10k
marked this pull request as ready for review
November 4, 2026 01:31
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Surefire fixed JVM arguments overwrite the JaCoCo agent, causing report/check to skip despite tests executing. Preserve the agent through an initialized dedicated property and late evaluation; keep all JVM options, production behavior, public APIs, tests, and the existing 90% warning threshold unchanged.
Pin the source build to the matching JWT issuer collection fix (PR easy-4-java/jwt-issuer#1), require execution data/XML for both modules with tests, and upload nested upstream coverage reports.
JDK 17 complete builds pass: JWT issuer 2 tests, Shiro core 1 test. Real coverage is JJWT 60/607 lines (9.88%) and Shiro core 0/1578 lines (0%); both warn below the unchanged target. Current Shiro test exercises Apache Shiro library behavior. Modules with no tests still have no data, and no whole-project coverage compliance is claimed. shiro-weixin and the Spring 6 bot migration are untouched.