Repository navigation
fix: resolve main reactor parent and verify source dependencies - #3
Merged
Merged
Conversation
loong10k
marked this pull request as ready for review
November 4, 2026 01:16
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main reactor cannot resolve its child parent from a clean Maven repository because the root uses an interpolated version while children request a literal version. Align the root coordinate, restore the missing INI test fixture and its optional logging dependency, and verify rejected credentials, successful login, and logout without changing production authentication defaults.
Add a main-only source verification workflow with JWT issuer pinned to fe29ffd8471eff70d2117b73e4cb2459e5ec4a2f, an isolated local repository, and public Maven Central resolution. Both upstream and project tests run.
Validation: JDK 17 complete clean install passed locally; JWT issuer ran 2 tests and Shiro extension ran 1 test. Existing JaCoCo execution data is missing because of inherited JVM argument configuration; this change does not claim 90% coverage or lower its configured threshold.