Add optional client-id in header for connect. resolves #81#83
Open
jetsfandb wants to merge 8 commits intoeasternbloc:masterfrom
Open
Add optional client-id in header for connect. resolves #81#83jetsfandb wants to merge 8 commits intoeasternbloc:masterfrom
jetsfandb wants to merge 8 commits intoeasternbloc:masterfrom
Conversation
Added support for specifying client-id in header on connect.
Update client.js
Updated tests for added optional connect header clientId value.
Update client.test.js
Fixed test case clientId parameter value.
Update client.test.js
Added missing tls parameter value in test by parameters.
Update client.test.js
jetsfandb
changed the title
jetsfandb
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added optional clientId constructor parameter for optional client-id connect header value.