add accept-version header to CONNET frame#56
Closed
jomo wants to merge 1 commit intoeasternbloc:masterfrom
Closed
Conversation
From the STOMP 1.1 specs: > From STOMP 1.1 and onwards, the CONNECT frame MUST include the accept-version header. It SHOULD be set to a comma separated list of incrementing STOMP protocol versions that the client supports. If the accept-version header is missing, it means that the client only supports version 1.0 of the protocol. > The protocol that will be used for the rest of the session will be the highest protocol version that both the client and server have in common. This commit allows using version 1.1 and thus ACK/NACK, however this does not introduce protocol negotiation and will likely cause issues if the server does not support version 1.1. Also, please be aware that extra headers required by 1.1 (such as the SUBSCRIBE id) still need to be added manually.
Author
|
Closing in favor of #64 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the STOMP 1.1 specs:
This PR allows using version 1.1 and thus ACK/NACK.
However, this does not introduce protocol negotiation and will likely cause issues in case the server does not support protocol version 1.1.
Also, please be aware that extra headers required by 1.1 (such as the SUBSCRIBE
id) still need to be added manually, e.g: