Added checks for rules about Requesting Agent. #13

EttoreM · 2025-09-25T13:17:20Z

Rules implemented

Description	sh:severity
The entity CreateAction MUST have the property agent pointing to the entity requesting the run	sh:Violation
The entity pointed to by the property agent of CreateAction MUST be of type Person.	sh:Violation
The agent of CreateAction SHOULD have the property affiliation	sh:Warning
The affiliation of a CreateAction's agent MUST point to an entity of type Organization	sh:Violation

|

Assumption

The checks have been devised under the following assumptions:

There may be entities of @type schema:Person that are not agents of a CreateAction entity.
Only schema:Person entities that are agents of CreateAction SHOULD have an affiliation (other schema:Person entities are not checked for affiliation)
Only affiliations of agents (if these have any) MUST be of @type schema:Organization (affiliations of other entities are not checked for @type).
There may be schema:Organizations that are not affiliations of any CreateAction's agent.

rocrate_validator/profiles/five-safes-crate/must/2_agent_entity.ttl

alexhambley · 2025-09-29T10:58:53Z

Will get to this Weds morning @EttoreM - apologies for the delay, it's the HDR Fed A roadmap Monday + Tues.

alexhambley

Hi @EttoreM - sorry for the delay! I have made some comments in-line :)

rocrate_validator/profiles/five-safes-crate/must/2_requesting_agent.ttl

rocrate_validator/profiles/five-safes-crate/should/2_requesting_agent.ttl

@id

…ck on @id being a permalink is now restricted to Organizations that are affiliations of agents.

…t (and possibly licence for RooDataEntity...???)

…s missing).

douglowe · 2025-10-27T16:40:15Z

I've rebased this branch from develop. I think I shouldn't have broken any of your code @EttoreM, but please could you check to make sure.

I don't know why git has flagged the removal of 1_funder.ttl and 1_root_data_entity_metadata.ttl files, when these are not part of the develop branch. Hopefully this will not break anything.

elichad · 2025-10-27T17:04:27Z

@douglowe Alas those files are on develop: https://github.com/eScienceLab/rocrate-validator/tree/develop/rocrate_validator/profiles/five-safes-crate/must (as well as in #15 ) so you might have accidentally removed them when rebasing

(this also looks to be why the tests are failing)

douglowe · 2025-10-27T17:18:30Z

yep. I've realised that, and have been checking to see if the tests are covered anywhere else.

I think that, as this PR is for the requesting agent, I'll reverse out the removal of these two files. If they do duplicate requirements elsewhere we can tidy up the duplication later.

This reverts commit d4b9c90.

This reverts commit e6bf3ae.

EttoreM · 2025-10-29T15:06:09Z

I have addresses @elichad's comments and added python tests to this set of rules.

I think it is ready for review.

elichad

@EttoreM this looks good to me!

My only suggestion is that we use the term "contextual entity" in messages instead of "IRI", as that is the terminology that RO-Crate users are more familiar with.

Please hit the merge button when you're ready as I'm not sure if you want this or #27 to be merged first (don't know if it matters).

elichad · 2025-10-29T15:23:32Z

rocrate_validator/profiles/five-safes-crate/must/2_requesting_agent.ttl

+    sh:minCount 1 ;
+    sh:nodeKind sh:IRI ;
+    sh:severity sh:Violation ;
+    sh:message "CreateAction MUST have at least one schema:agent that is an IRI." ;


We could refer to this as a contextual entity to suit our audience better (though I appreciate this just replaces RDF jargon with RO-Crate jargon...)

Suggested change

sh:message "CreateAction MUST have at least one schema:agent that is an IRI." ;

sh:message "CreateAction MUST have at least one schema:agent that is a contextual entity." ;

elichad · 2025-10-29T15:24:28Z

rocrate_validator/profiles/five-safes-crate/must/2_requesting_agent.ttl

+    sh:nodeKind sh:IRI ;
+    sh:class schema:Person ;
+    sh:severity sh:Violation ;
+    sh:message "Each CreateAction agent MUST be typed as schema:Person and be an IRI." ;


since the IRI/contextual entity part is covered above

Suggested change

sh:message "Each CreateAction agent MUST be typed as schema:Person and be an IRI." ;

sh:message "Each CreateAction agent MUST be typed as schema:Person." ;

elichad · 2025-10-29T15:33:02Z

rocrate_validator/profiles/five-safes-crate/must/2_requesting_agent.ttl

+    sh:class schema:Organization ;
+    sh:nodeKind sh:IRI ;
+    sh:severity sh:Violation ;
+    sh:message "The affiliation of a CreateAction's agent MUST be a schema:Organization and be an IRI." ;


Suggested change

sh:message "The affiliation of a CreateAction's agent MUST be a schema:Organization and be an IRI." ;

sh:message "The affiliation of a CreateAction's agent MUST be a contextual entity with type schema:Organization." ;

elichad · 2025-10-29T15:44:16Z

rocrate_validator/profiles/five-safes-crate/should/2_requesting_agent.ttl

(note for my own benefit as I think you're already aware of this)

GH interprets this as a renamed file ...rate/must/1_root_data_entity_metadata.ttl → ...safes-crate/should/2_requesting_agent.ttl

and this might therefore have conflicts with #27 which also updates the 1_root_data_entity_metadata.ttl file (but #27 also renames the file, so maybe it'll be fine!?).

Yes, it should be fine.

elichad · 2025-10-29T15:45:25Z

tests/integration/profiles/five-safes-crate/test_5src_root_data_entity_metadata.py

(another note for myself) this file is updated with a different filename in #27

elichad · 2025-10-29T15:47:12Z

rocrate_validator/profiles/five-safes-crate/must/1_funder.ttl

cross-referencing #27 (comment) which confirms that this is fine to remove

EttoreM assigned stain, alexhambley and douglowe Sep 25, 2025

douglowe requested review from alexhambley, douglowe and stain September 25, 2025 13:22

douglowe assigned douglowe and EttoreM and unassigned stain, douglowe and alexhambley Sep 25, 2025

douglowe reviewed Sep 25, 2025

View reviewed changes

rocrate_validator/profiles/five-safes-crate/must/2_agent_entity.ttl Outdated Show resolved Hide resolved

EttoreM requested a review from douglowe September 29, 2025 11:53

alexhambley reviewed Oct 7, 2025

View reviewed changes

EttoreM requested a review from alexhambley October 8, 2025 09:21

EttoreM changed the title ~~Added checks for rules about responsible Agent.~~ Added checks for rules about Requesting Agent. Oct 8, 2025

EttoreM changed the base branch from 9-profile-for-5-safes-ro-crate-version-05 to develop October 16, 2025 13:18

elichad reviewed Oct 16, 2025

View reviewed changes

rocrate_validator/profiles/five-safes-crate/should/2_requesting_agent.ttl Show resolved Hide resolved

douglowe and others added 10 commits October 27, 2025 11:01

5-safes crate first req

7db7e57

5S-crate funder test added

58dd74e

renumber funder test for now

2a838d4

Added chekts for rules about responsible Agent.

c1f3b20

Ammended test checking that agent SHOULD have an affiliation.

ead5e13

Removed typo.

b23331c

1) Now a CreateAction entity can have more than 1 agent. 2) Also, che…

d908049

…ck on @id being a permalink is now restricted to Organizations that are affiliations of agents.

Renamed files containing tests for 'requesting agent'.

a94fa09

Refactored code

2147180

Addressed most of Alex' review points. Still need to address copyrigh…

b32899f

…t (and possibly licence for RooDataEntity...???)

EttoreM added 3 commits October 27, 2025 14:38

Addressed copyright plus licence for one of the ttl file (where it wa…

3461493

…s missing).

removed outdated file

e6bf3ae

removed outdated file 2

d4b9c90

douglowe force-pushed the 11-responsible-agent branch from 73a78a9 to d4b9c90 Compare October 27, 2025 16:33

EttoreM linked an issue Oct 27, 2025 that may be closed by this pull request

Requesting Agent #11

Closed

douglowe added 2 commits October 27, 2025 17:19

Revert "removed outdated file 2"

7524991

This reverts commit d4b9c90.

Revert "removed outdated file"

27f8555

This reverts commit e6bf3ae.

EttoreM requested a review from elichad October 28, 2025 09:37

EttoreM added 2 commits October 29, 2025 14:55

Added tests for ruleset 2. Also addressed Eli's comments on the PR.

e5bd352

Fixed linting error.

1ebaf4d

elichad approved these changes Oct 29, 2025

View reviewed changes

Replaced 'IRI' with 'contextual entity'.

8d569e9

EttoreM merged commit a1dd141 into develop Oct 29, 2025
4 checks passed

EttoreM deleted the 11-responsible-agent branch October 29, 2025 19:40

elichad mentioned this pull request Oct 30, 2025

21 referencing a workflow crate mk2 #28

Merged

	sh:message "CreateAction MUST have at least one schema:agent that is an IRI." ;
	sh:message "CreateAction MUST have at least one schema:agent that is a contextual entity." ;

	sh:message "Each CreateAction agent MUST be typed as schema:Person and be an IRI." ;
	sh:message "Each CreateAction agent MUST be typed as schema:Person." ;

	sh:message "The affiliation of a CreateAction's agent MUST be a schema:Organization and be an IRI." ;
	sh:message "The affiliation of a CreateAction's agent MUST be a contextual entity with type schema:Organization." ;

Added checks for rules about Requesting Agent. #13

Added checks for rules about Requesting Agent. #13

Uh oh!

Conversation

EttoreM commented Sep 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rules implemented

Assumption

Uh oh!

Uh oh!

alexhambley commented Sep 29, 2025

Uh oh!

alexhambley left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

douglowe commented Oct 27, 2025

Uh oh!

elichad commented Oct 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

douglowe commented Oct 27, 2025

Uh oh!

EttoreM commented Oct 29, 2025

Uh oh!

elichad left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

EttoreM commented Sep 25, 2025 •

edited

Loading

elichad commented Oct 27, 2025 •

edited

Loading