Repository navigation
fix(player): correct buffering state, remember volume and reduce metadata requests - #300
Merged
Merged
Conversation
|
ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing |
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When audio buffers, the player previously retained its actual-playing flag. Clear that flag on waiting so animations and shared playback state follow actual playback; a network stalled event only enters buffering when the media lacks future data. Prioritize offline status over a previous stream error.
Persist and safely restore volume/mute before binding volume listeners, without authorizing autoplay or assigning iOS system volume. Skip metadata requests while offline or hidden and idle, while preserving background playback metadata and visible schedule browsing. Cache successful lyrics by media ID with a 20-entry limit; failures remain retryable.
Validation:
Updates docs/PROJECT_CONTEXT.md with the playback and preference rules. This PR does not replace the separate security hardening PR #299. Detailed stream error classification remains follow-up work.