Repository navigation
fix: auto-scroll radio schedule to current on-air slot - #290
Merged
Merged
Conversation
…scrolling programme guides
…ng manual scrolling
|
ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing |
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
ePlus-DEV is on CodeRabbit Free, which includes PR summaries. Ask your admin to upgrade for code reviews.
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Queue → Schedule panel highlighted the current VOV Giao thông programme but started scrolled at 04:00 every time (the example shows FM91 at 14:30 well below the fold).
Fix
startTime <= now < endTime; in gaps, scroll to the next upcoming slot (or last elapsed), without falsely highlighting a broadcast. Keep legacy provider EPG behavior (first current programme) unchanged.overflow-y-autocontainer via scrollTop, never the overall page/slideover.Validation
npm testfor time interval boundaries, gaps and provider regression; opt-in Playwright scenarios for exact 15:00 ICT auto-scroll, manual browsing, re-center button and a gap. CI must pass full prerender and SEO audits.Target
develop. Existing production release #289 will pick up the fix when this branch merges and must then pass its updated CI before production deploy.