Skip to content

fix: auto-scroll radio schedule to current on-air slot - #290

Merged
hoangsvit merged 15 commits into
developfrom
fix/schedule-scroll-current-20261014
Oct 14, 2026
Merged

hoangsvit merged 15 commits into
developfrom
fix/schedule-scroll-current-20261014

Conversation

@hoangsvit

Copy link
Copy Markdown
Member

Problem

The Queue → Schedule panel highlighted the current VOV Giao thông programme but started scrolled at 04:00 every time (the example shows FM91 at 14:30 well below the fold).

Fix

  • Auto-position the inner queue scroller around the current programme when opening the Schedule tab, opening the desktop sidebar or mobile drawer, switching stations, or receiving fresh schedule data.
  • Recalculate the live highlight every 15 seconds and follow the next slot only if the visitor has not manually scrolled. Once the visitor browses, do not hijack their scroll position; re-entering the tab or clicking Jump to current time restores it.
  • For reference guides, only mark a slot as live when startTime <= now < endTime; in gaps, scroll to the next upcoming slot (or last elapsed), without falsely highlighting a broadcast. Keep legacy provider EPG behavior (first current programme) unchanged.
  • Scroll only the queue's own overflow-y-auto container via scrollTop, never the overall page/slideover.
  • Expose explicit visibility from both Player Queue instances so an initially hidden desktop panel still recenters on each open.
  • Localize the jump action to 7 supported locales.

Validation

npm test for time interval boundaries, gaps and provider regression; opt-in Playwright scenarios for exact 15:00 ICT auto-scroll, manual browsing, re-center button and a gap. CI must pass full prerender and SEO audits.

Target develop. Existing production release #289 will pick up the fix when this branch merges and must then pass its updated CI before production deploy.

@qodo-code-review

Copy link
Copy Markdown

ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing

@coderabbitai

coderabbitai Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: ePlus-DEV/radio.eplus.dev/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Free
  • Run ID: b2bf2bd5-eff6-4602-b1fa-073f997354bd

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

ePlus-DEV is on CodeRabbit Free, which includes PR summaries. Ask your admin to upgrade for code reviews.

  • Ask an admin to upgrade

Open in CodeRabbit

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@hoangsvit
hoangsvit merged commit 9bc7961 into develop Oct 14, 2026
1 check passed
@hoangsvit
hoangsvit deleted the fix/schedule-scroll-current-20261014 branch October 14, 2026 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant