fix: fix page break issue when document has images#531
Open
kassah-mahmoud wants to merge 1 commit intoeKoopmans:mainfrom
Open
fix: fix page break issue when document has images#531kassah-mahmoud wants to merge 1 commit intoeKoopmans:mainfrom
kassah-mahmoud wants to merge 1 commit intoeKoopmans:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Page break produces unpredictable behavior when the document has images
This is due to the fact that the images may be fully loaded and rendered or not while calculating the element's rects values, which leads to incorrect calculations. As a result, page breaks and hyperlinks are located in incorrect positions.
In this PR, the worker chain make sure that all images are fully loaded then execute the page break logic
This modification solved the issues in my project so I made this PR