Add scale option for page break pad height#252
Closed
timup wants to merge 1 commit intoeKoopmans:masterfrom
timup:master
Closed
Add scale option for page break pad height#252timup wants to merge 1 commit intoeKoopmans:masterfrom timup:master
timup wants to merge 1 commit intoeKoopmans:masterfrom
timup:master
Conversation
Author
|
It looks like #170 handles this same issue... perhaps in a better way. |
Author
|
Yes - #170 handles this, but without the need for an additional option. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an option to the
optparameter, scale. Scale is intended as a multiplier for the page break pad height. In my use case, I am creating a canvas twice as wide as the eventual pdf, so that charts render in their full width, however this influences the page break feature - the page height is only 1/2 the height needed, when I have doubled the width.The screenshot shows the result- where the page break pad is only 1/2 the height that it needs to be. I'm sure there's a better way to name this, or a more universal way to work this in, so I am open to any suggestions and can rework this as needed.