SDSTOR-24993, SDSTOR-25623: propagate journal flush I/O errors and fail-stop on unrecoverable flush failure - #917
Open
shosseinimotlagh wants to merge 1 commit into
Conversation
…il-stop on unrecoverable flush failure Propagate journal flush I/O errors to the write_async callback instead of swallowing them, and fail-stop when a flush failure is unrecoverable so the process doesn't keep operating against a corrupted log.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## stable/v7.x #917 +/- ##
==============================================
Coverage ? 48.27%
==============================================
Files ? 110
Lines ? 13136
Branches ? 6343
==============================================
Hits ? 6342
Misses ? 2564
Partials ? 4230 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
log_write_comp_cb_t/log_req_comp_cb_tnow carry astd::error_condition status.LogDev::on_flush_completion()always fires the completion callback -- success or failure -- instead of returning early on async_pwritevfailure and never calling back at all.HomeRaftLogStore::append/write_atandSoloReplDev::write_journalnow check that status: on a flush I/O error they escalate viafault_cmt_serviceif the embedder registered one, otherwise fail-stop (HS_REL_ASSERT), instead of silently treating a non-durable write as committed.Test plan
FlushIOErrorPropagatesToCallback,FlushIOErrorPropagatesToEveryRequestInGroupintest_log_store.cpp, using a_PRERELEASEflip to force a flush failure.test_log_store/test_log_store_long_runsuites updated mechanically for the new callback signature and pass.