Repository navigation
fix(orchestrator): preserve workdir metadata with login diagnostics - #3773
Open
boxrouter-maintainer wants to merge 1 commit into
Open
boxrouter-maintainer wants to merge 1 commit into
boxrouter-maintainer wants to merge 1 commit into
Conversation
boxrouter-maintainer
requested review from
ValentaTomas and
jakubno
as code owners
October 29, 2026 22:53
|
We require contributors to sign our Contributor License Agreement, and we don't have @boxrouter-maintainer on file. You can sign our CLA at https://e2b.dev/docs/cla . Once you've signed, post a comment here that says '@cla-bot check' |
Author
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
saveWorkdirMetaresolves the working directory through a login shell, but previously discarded the image'sEnvVarsand treated any stderr output as a failed lookup. Login hooks that emit diagnostics could therefore break workdir metadata resolution even when the command succeeded.Pass the image environment to the lookup command and identify its final absolute path with a dedicated marker. Collect streamed stdout and stderr, accept a valid marked path when the command succeeds, and preserve command failures and all metadata except the resolved
WorkDir.Validation:
go test ./pkg/template/build/commands -run 'TestSaveWorkdirMetaFromOutput' -count=1git diff --check