feat: support switch to UTC for usage page#504
Open
drankou wants to merge 3 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Near month ends "this-month" also fell within the loose 24h tolerance of "last-30-days", and findMatchingPreset returned the first match, so pinning to UTC could drop a day from the range. The closest preset now wins, the tolerance is shared between highlight and re-anchoring, and setPinnedToUtc uses a functional URL update so it stays stable across timeframe changes.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 35133c3b3c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…nchoring On the 30th of a 30-day month "this-month" and "last-30-days" produce identical ranges, so the re-anchor match is a pure tie. When the user's timezone is a calendar day ahead of UTC, guessing the rolling preset rewrote the pinned view to a window missing the billing month. The re-anchor path now matches calendar-anchored presets first; the popover order and highlight behavior are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a page-scoped UTC switch to the usage page so displayed totals can match billing, which aggregates over UTC calendar boundaries.
utcquery param — the persisted timezone preference is untouchedTimezoneOverrideprovider that shadowsuseTimezone()for the subtree, so existing consumers need no changescloses DASH-162