fix: check that a replacement is not mapped to itself#540
Open
fix: check that a replacement is not mapped to itself#540
Conversation
43081j
reviewed
Apr 8, 2026
43081j
reviewed
Apr 8, 2026
| deleteProperty(obj, 'foo.bar.baz') // [!code --] | ||
| objectPath.del(obj, 'foo.bar.baz') // [!code ++] | ||
| const value = getProperty(obj, 'foo.bar.baz') | ||
| ``` |
Contributor
There was a problem hiding this comment.
Suggested change
| ``` | |
| ``` | |
| Note that this is assuming you do not consume dot paths as user input. If you do, ensure you sanitize keys before accessing them (e.g. through `Object.hasOwn`). |
43081j
reviewed
Apr 8, 2026
| "type": "module", | ||
| "moduleName": "dot-prop", | ||
| "replacements": ["dlv", "object-path"], | ||
| "replacements": ["dlv", "dset"], |
Contributor
There was a problem hiding this comment.
this isn't quite right.
dlv and dset do different jobs, but by having both in this array, you're saying they are equal replacements to dot-prop.
probably best to leave it as dlv only and mention dset in the doc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Closes #526
Closes #534
📚 Description
check that a replacement is not mapped to itself