Skip to content

Replace mockdate#507

Merged
43081j merged 6 commits intoe18e:mainfrom
joaopedrodcf:joaopedrodcf/mockdate
Apr 8, 2026
Merged

Replace mockdate#507
43081j merged 6 commits intoe18e:mainfrom
joaopedrodcf:joaopedrodcf/mockdate

Conversation

@joaopedrodcf
Copy link
Copy Markdown
Contributor

@joaopedrodcf joaopedrodcf commented Apr 6, 2026

🔗 Linked issue

Closes #487

📚 Description

AI was used an code was reviewed

@gameroman
Copy link
Copy Markdown
Contributor

@joaopedrodcf could you also update the description to have Closes #487 instead of just #487 please. Thank you

},
"node:test": {
"id": "node:test",
"type": "documented",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be a native type

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and url should point to nodejs docs

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the points this was done 🙏

joaopedrodcf and others added 4 commits April 7, 2026 21:56
Co-authored-by: James Garbutt <43081j@users.noreply.github.com>
Co-authored-by: James Garbutt <43081j@users.noreply.github.com>
Co-authored-by: James Garbutt <43081j@users.noreply.github.com>
@joaopedrodcf joaopedrodcf force-pushed the joaopedrodcf/mockdate branch 3 times, most recently from e68c876 to 929106b Compare April 7, 2026 21:04
Co-authored-by: James Garbutt <43081j@users.noreply.github.com>
@joaopedrodcf joaopedrodcf force-pushed the joaopedrodcf/mockdate branch from 929106b to cf4753d Compare April 7, 2026 21:08
@joaopedrodcf joaopedrodcf requested a review from gameroman April 7, 2026 21:09
@joaopedrodcf
Copy link
Copy Markdown
Contributor Author

@gameroman @43081j updated the PR 🙏

Copy link
Copy Markdown
Contributor

@gameroman gameroman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems correct

Co-authored-by: James Garbutt <43081j@users.noreply.github.com>
@43081j 43081j merged commit 4c7cfd8 into e18e:main Apr 8, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Replacement]: mockdate

3 participants