feat(micro-utilities): add is-property to replacements - #1087
Open
dreyfus92 wants to merge 1 commit into
Open
Conversation
43081j
reviewed
Sep 5, 2026
| "id": "snippet::is-identifier-name", | ||
| "type": "simple", | ||
| "description": "You can test a string against the `ID_Start` and `ID_Continue` Unicode properties to check whether it is a valid identifier name, and so usable as an unquoted property.", | ||
| "example": "const identifierNameRE = /^[$_\\p{ID_Start}][$\\u200c\\u200d\\p{ID_Continue}]*$/u;\n\nconst isProperty = (str) => identifierNameRE.test(str);" |
Contributor
There was a problem hiding this comment.
i think we could simplify this a bunch:
- inline it into the
isPropertyfunction - remove
u200dandu200csince only insane people would put those in property names afaict
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
closes: #1025
📚 Description
adds
is-propertyto the micro-utilities manifest