Skip to content

feat(native): add source-map-support to replacements - #1086

Open
dreyfus92 wants to merge 1 commit into
mainfrom
add/mr-025
Open

feat(native): add source-map-support to replacements#1086
dreyfus92 wants to merge 1 commit into
mainfrom
add/mr-025

Conversation

@dreyfus92

Copy link
Copy Markdown
Member

🔗 Linked issue

closes: #1027

📚 Description

adds source-map-support and @cspotcode/source-map-support to the native manifest

setSourceMapsSupport(true, { nodeModules: true, generatedCode: true }) // [!code ++]
```

The register import maps the same way:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The register import maps the same way:
Then register import maps the same way:

Comment thread manifests/native.json
"module.setSourceMapsSupport",
"--enable-source-maps",
"process.setSourceMapsEnabled",
"module.findSourceMap"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't do the same job as the other 3 so can't really be listed here. these replacements are all meant to be equivalent, i.e. you choose one. its not an AND, its an OR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Replacement]: source-map-support

2 participants