feat: add workflow that rotates client secrets in azure automatically#87
Open
feat: add workflow that rotates client secrets in azure automatically#87
Conversation
barkerl
requested review from
JoshCarter-ops,
Wi11Shell,
cmarstondvsa,
dhcrees,
dineshkmuardvsa,
matbeales and
matthew2564
matthew2564
reviewed
Oct 14, 2025
Comment on lines
+81
to
+84
| run: | | ||
| aws secretsmanager put-secret-value \ | ||
| --secret-id "${{ inputs.aws-secret-id }}" \ | ||
| --secret-string "{\"clientId\":\"$CLIENT_ID\",\"clientSecret\":\"$AZURE_NEW_SECRET\"}" |
Contributor
There was a problem hiding this comment.
The workflow looks good to me, the only query I have is re this last bit.
Would it make sense that AZURE_NEW_SECRET is an output to this workflow instead of updating in place?
Currently, for example, the equivalent CVS secret has more detail that just clientId & clientSecret in the JSON, therefore this would overwrite those extra values.
The other option would be we retrieve the secret as is and merge the two objects together, which will update these keys but also retain the other contents?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Re-usable workflow that will rotate a cliend secret for an existing clientID in AWS.
Related issue: JIRA_TICKET_NUMBER
Before submitting (or marking as "ready for review")