Skip to content

Cover workflow definition contracts - #460

Merged
rmcdaniel merged 1 commit into
mainfrom
test/workflow-definition-contract-coverage
Sep 1, 2026
Merged

Cover workflow definition contracts#460
rmcdaniel merged 1 commit into
mainfrom
test/workflow-definition-contract-coverage

Conversation

@rmcdaniel

Copy link
Copy Markdown
Member

Summary

  • cover workflow definition command discovery, aliases, portable parameter contracts, and invalid definitions
  • prove duplicate durable query, update, and signal names fail before worker registration becomes ambiguous
  • cover inherited and trait-backed definition fingerprints and the final nullable query-metadata fallback
  • advance the accepted coverage floor to the 85.53% result already proven on main

Verification

  • WorkflowDefinitionContractTest: 10 tests, 63 assertions
  • modified query-contract case: 1 test, 2 assertions
  • ECS: clean
  • PHPStan: clean
  • coverage ratchet self-test: passed
  • public-boundary scan: passed

Progresses #426.

@rmcdaniel
rmcdaniel merged commit 5ddd15a into main Sep 1, 2026
15 checks passed
@rmcdaniel
rmcdaniel deleted the test/workflow-definition-contract-coverage branch September 1, 2026 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants