Skip to content

Recognize main in coverage contracts #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rmcdaniel merged 1 commit into from
Sep 1, 2026
Merged

Recognize main in coverage contracts #459

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions resources/v2-unit-coverage-contract.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"schema_version": 1,
"branch": "v2",
"branch": "main",
"measurement": {
"metric": "line",
"test_suite": "unit",
Expand All @@ -16,6 +16,6 @@
},
"provenance": {
"observed_at": "2026-09-01",
"evidence": "The local unit-only command retains the existing 60.00% floor for fast feedback. Public branch qualification uses the combined unit and MySQL feature contract in v2-coverage-contract.json."
"evidence": "The local unit-only command retains the existing 60.00% floor for fast feedback. Public main-branch qualification uses the combined unit and MySQL feature contract in v2-coverage-contract.json."
}
}
6 changes: 3 additions & 3 deletions scripts/ci/check-v2-coverage.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,8 +114,8 @@ function summarize_coverage(string $root, array $clovers, array $contract): arra
fail('Coverage contract schema_version must be 1.');
}

if ($branch !== 'v2' || $metric !== 'line' || $suffix !== '.php') {
fail('Coverage contract must measure v2 PHP line coverage.');
if ($branch !== 'main' || $metric !== 'line' || $suffix !== '.php') {
fail('Coverage contract must measure main-branch PHP line coverage.');
}

if (! is_array($excludedPaths) || $excludedPaths !== []) {
Expand Down Expand Up @@ -559,7 +559,7 @@ function self_test(string $root): void

$contract = [
'schema_version' => 1,
'branch' => 'v2',
'branch' => 'main',
'measurement' => [
'metric' => 'line',
'test_suite' => 'unit',
Expand Down