Skip to content

Complete durable workflow query contract coverage #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rmcdaniel merged 1 commit into from
Sep 1, 2026
Merged

Complete durable workflow query contract coverage #458

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions resources/v2-coverage-contract.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"schema_version": 1,
"branch": "v2",
"branch": "main",
"measurement": {
"metric": "line",
"test_suite": "unit+feature-mysql",
Expand All @@ -12,11 +12,11 @@
}
},
"ratchet": {
"accepted_baseline_basis_points": 8530,
"accepted_baseline_basis_points": 8551,
"target_basis_points": 10000
},
"provenance": {
"observed_at": "2026-09-01",
"evidence": "Public full qualification run 33469360974 measured 51,474 of 60,342 executable lines (85.30%) at commit adc71e1b54351274c06ca315a32fb6a8e21135c3 by unioning one unit report with all four MySQL feature-shard reports across the complete production source inventory."
"evidence": "Public full qualification run 33520656271 measured 51,604 of 60,342 executable lines (85.51%) at commit 125078474405030d161bd0b287d71339a2d6c0fa by unioning one unit report with all four MySQL feature-shard reports across the complete production source inventory."
}
}
62 changes: 62 additions & 0 deletions tests/Unit/V2/WorkflowQueryContractTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,6 +230,68 @@ public function testItRejectsNullAndImpossibleDeclaredTypes(): void
], $result['validation_errors']);
}

public function testItSupportsDurableParametersWithoutCompleteTypeMetadata(): void
{
$run = $this->runWithQueryContract('partial-type-metadata', [
[
'name' => 'untyped',
'required' => true,
],
[
'name' => 'empty_type',
'type' => '',
'required' => true,
],
[
'name' => 'nullable_short',
'type' => '?string',
'required' => true,
],
[
'name' => 'nullable_union',
'type' => 'string|null',
'required' => true,
],
[
'name' => 'explicit_nullable',
'type' => 'string',
'required' => true,
'allows_null' => true,
],
[
'name' => 'mixed_union',
'type' => 'int|mixed',
'required' => true,
],
]);

$result = WorkflowQueryContract::validatedArgumentsForRun($run, 'typed-query', [
'untyped' => new stdClass(),
'empty_type' => null,
'nullable_short' => null,
'nullable_union' => null,
'explicit_nullable' => null,
'mixed_union' => [],
]);

$this->assertSame([], $result['validation_errors']);
$this->assertCount(6, $result['arguments']);
}

public function testItUsesTheGenericArgumentNameForMalformedDurableParameters(): void
{
$run = $this->runWithQueryContract('missing-parameter-name', [[
'type' => 'string',
]]);

$result = WorkflowQueryContract::validatedArgumentsForRun($run, 'typed-query', [123]);

$this->assertSame([123], $result['arguments']);
$this->assertSame([
'argument' => ['The argument argument must be of type string.'],
], $result['validation_errors']);
}

public function testItUsesSafeFallbacksWhenNoDurableOrLoadableContractExists(): void
{
$run = $this->runWithQueryContract('fallback', []);
Expand Down