Skip to content

Fix timer replay#336

Merged
rmcdaniel merged 1 commit intomasterfrom
fix/timer-resolve
Feb 23, 2026
Merged

Fix timer replay#336
rmcdaniel merged 1 commit intomasterfrom
fix/timer-resolve

Conversation

@rmcdaniel
Copy link
Member

Issue: Timer logs store “timer completed” (true), but awaitWithTimeout returns “condition met before timeout,” which is the inverse. On replay, returning raw timer log values flips false -> true.

@rmcdaniel rmcdaniel merged commit 4148e90 into master Feb 23, 2026
1 check passed
@rmcdaniel rmcdaniel deleted the fix/timer-resolve branch February 23, 2026 17:19
@codecov
Copy link

codecov bot commented Feb 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (a8f78e8) to head (5d320c7).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##              master      #336   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity       563       564    +1     
===========================================
  Files             61        61           
  Lines           1937      1940    +3     
===========================================
+ Hits            1937      1940    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant