Repository navigation
Shared fixtures and native tests: keep service-calls' SQLite pause; bound parallel timer waits - #824
Conversation
#815 recorded update-validation and service-calls in the SQLite main corpus with published PHP's maintenance loop running. In #821's merge-group run 40579733447, published 2.11.5's service-calls record stopped ("No charge with options.id for a later path") after 2.11.5 exhausted its control-plane SQLite contention retries on a workflow_service_calls insert while the loop ran its repair pass. That is one failure in five full SQLite runs since #815, and #796 is still open. The SQLite job and the native image corpus again exclude service-calls from the main corpus and record it with update-validation-sqlite.sh, which stops PHP's maintenance loop for the PHP record only. update-validation stays in the main corpus (#726 has installed acceptance). The script, php-maintenance-window.sh and their tests are restored from before #815, pointing at the 2.11.5 baseline. The port log and a checkpoint record the walk-back. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
parallel_all's wait_for_timer gave a 3-second timer 3 seconds from the call to fire. In #821's merge-group run 40579733447 the PostgreSQL native-tests job (631 s for the suite) failed nested_mixed_barrier_retains_all_paths_and_original_timer_after_cold_reopen with "original all-group timer did not fire". The waits are positive: they return as soon as TimerFired is recorded, so a longer bound only changes how long a real failure takes to report. The three timer-fire waits in the file now share a 15-second bound. parallel_all passes 11/11 on SQLite. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
|
Cloud review of exact head Both the SQLite workflow and native-image corpus exclude only The maintenance guard checks the exact job-scoped container, arms restoration before stopping it, and leaves that restoration armed until the loop stays running through the sustained check. The restored retry path retains the first failure evidence and permits one PHP retry only with a same-record-window SQLite lock observation and a fresh shared prefix. Other PHP failures and all native/embedded failures remain fatal. The native test delta changes only three positive timer-wait bounds; the existing event assertions are unchanged. This was a static review of the scripts, workflow wiring, changed tests and timer diff. I did not execute Rust, repeat the owner's unit runs or establish hosted end-to-end acceptance. It also does not attribute #812's separate failed corpus comparison, whose runtime and fixture remain unconfirmed. Protected qualification remains required. |



Part of #325. Walks back part of #815, as recorded in the checkpoint.
What failed. In #821's merge-group run 40579733447 (
execution-and-codec (corpus)), published 2.11.5'sservice-callsrecord stopped withNo charge with options.id for a later path.Control-plane storage contention exhausted retries/ SQLitedatabase is lockedon aworkflow_service_callsinsert while its maintenance loop ran.backend_lock_pressurethe probe retries. An earlier execute did get that reply and was retried.Why walk it back. That's one failure in five full SQLite runs since #815, and #796 is still open. General's 10/10 check ran isolated namespaces, not full-corpus load, so I over-read it in #815.
Change
native-image-corpus.shexcludeservice-callsfrom the main corpus again. They record it withupdate-validation-sqlite.sh … service-calls, which stops PHP's maintenance loop for the PHP record only.update-validationstays in the main corpus: Update-validation poll loses writes and its typed refusal under database lock pressure #726 is closed with installed acceptance.php-maintenance-window.shand their unit tests are restored from before Rust #325: move the Shared Server fixtures reference to published 2.11.5 #815, pointing at the 2.11.5 baseline. The workflow test lists and paths are restored too.service-callsin their main corpus.Checked locally:
ServerParityFixtureSelectionTest,ServerParityUpdateValidationRetryTest,PhpMaintenanceWindowTestandServerParityImagePullTest: 24/24. The end-to-end SQLite job runs in this PR's CI.Second commit: native test bound. In the same run, the PostgreSQL native-tests job (631 s suite) failed
parallel_all::nested_mixed_barrier_retains_all_paths_and_original_timer_after_cold_reopenwith "original all-group timer did not fire". The helper gave a 3-second timer 3 seconds from the call. The three positive timer-fire waits inparallel_all.rsnow share a 15-second bound. They still return as soon asTimerFiredis recorded, so only failure reporting is slower.parallel_allpasses 11/11 on SQLite.🤖 Generated with Claude Code