Skip to content

Shared fixtures: wait for the embedded pending timer before cancelling it #821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rmcdaniel merged 1 commit into from
Oct 27, 2026
Merged

Shared fixtures: wait for the embedded pending timer before cancelling it #821

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion scripts/conformance/server-parity/cancellation-probe.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,20 @@ function embeddedCancellationObservation(array $fixture, string $workflowId, str
if ($phase === 'before_claim') {
cancelEmbeddedRun($stub->runId());
} elseif ($phase === 'pending_timer') {
Artisan::call('queue:work', ['connection' => 'database', '--queue' => $queue, '--once' => true, '--sleep' => 0, '--tries' => 1]);
// The declared phase is a scheduled timer. One queue job can return
// before the workflow task is available, so work single jobs until
// the run has recorded TimerScheduled (bounded), then cancel.
$deadline = microtime(true) + 15;
do {
Artisan::call('queue:work', ['connection' => 'database', '--queue' => $queue, '--once' => true, '--sleep' => 0, '--tries' => 1]);
$scheduled = in_array('TimerScheduled', array_column(embeddedCancellationHistory($stub->runId()), 'event_type'), true);
if (! $scheduled) {
usleep(100_000);
}
} while (! $scheduled && microtime(true) < $deadline);
if (! $scheduled) {
throw new \RuntimeException('The embedded run did not reach its pending timer before the cancellation phase.');
}
cancelEmbeddedRun($stub->runId());
}
Artisan::call('queue:work', ['connection' => 'database', '--queue' => $queue, '--stop-when-empty' => true,
Expand Down
Loading