[rmcdaniel]

Fixes the corrected-cohort python-clock-genuine-one flake (false !== true after the published PHP portable record passes). It has occurred twice: run 40151134683, and run 40206210357 on #762. It's classified on #754 (comment 6399755214).

Cause

tests/Fixtures/ServerParityProfiles/corrected-markers/python-clock-genuine-one.json declares "cancel_unsent_original_polls": true: the SIGKILLed original Python author may have polls in flight that end before the observing proxy forwards them. Only corrected-marker-contract.mjs implemented that. corrected-clock-contract.mjs still required every client-cancelled poll to show request_body_complete=true and upstream_request_started=true.

In run 40206210357 the published PHP clock record's requests[34] POST /api/worker/activity-tasks/poll 0 client_cancelled=true had neither flag set. It sat between the original's registration ([15]), its durable admission ([29]) and its explicit retirement ([35] DELETE …workflow:original). The PHP server never received that request.

Change

• scripts/conformance/server-parity/killed-author-poll.mjs (new): the corrected-marker contract's unsent-poll branch, moved unchanged into checkUnsentKilledAuthorPoll. An unsent poll is admitted only when all of these hold:
  • the fixture declares cancel_unsent_original_polls;
  • the author is Python, stopped by SIGKILL, with exit code -9;
  • the route is a declared no-result poll;
  • it carries no bytes, no response and no forwarding;
  • it falls after the original's real registration and recorded durable admission, and before its explicit retirement.
• corrected-marker-contract.mjs calls it in place of the inline branch; its other checks are unchanged. corrected-clock-contract.mjs calls it for a cancelled poll that was never forwarded, and keeps its existing checks for every forwarded one.
• corrected-markers/check-clock-readers.mjs gains the corrected-marker reader's unsent-cancellation counterexamples, plus one more ("after original retirement"). They run on any actual clock record that contains such a poll.
• tests/Unit/ServerParityKilledAuthorPollTest.mjs (new; in the path filter and the comparator list): the failing record's shape passes for each poll route. Each of 19 counterexamples is refused, including a received body, invented bytes, forwarding or response, a missing or foreign registration, a missing or unrecorded admission, a missing or earlier retirement, an undeclared fixture, a graceful shutdown, another producer, a living author and an undeclared poll kind.

Qualification

• New unit test 2/2 (19 refusals). Comparator node tests 2241/2241. All four changed modules pass node --check. Docker workflow isolation policy passes.
• No native, shared or frozen implementation changes and no fixture changes. The corrected-marker contract's behavior is unchanged; only its code moved. CI runs the corrected-markers and clock profiles on every database.

🤖 Generated with Claude Code

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[rmcdaniel]

Cloud bounded wrapper review of exact fecc5bf24cfc27626b906d3667bda29dcf8d6ac8 (now merged): no finding in the shared killed-author-poll.mjs, the two changed contract call sites, or the clock-reader mutation controls.

The unsent branch requires the declared Python/SIGKILL case, author exit -9, a declared no-result poll, no received request/response bytes or forwarding, preceding original-worker registration and recorded durable admission, and subsequent explicit retirement. It returns no request authority. The clock caller retains transport checks; forwarded polls keep their existing path.

Independent verification: both helper unit tests passed, including all 19 refusal cases, in an isolated Node 22.23.4 container. The clock-reader source was reviewed but was not executed against records. This review covers the outer wrapper and fake controls only; it makes no new runtime, payload, or publication claim.