Repository navigation
Native: ignore a caller's trace context where PHP Server admits it - #566
Merged
Merged
Conversation
PHP Server's optional tracing admits a top-level observability_context on start, signal, update, cancel and request-cancellation requests. Published PHP 2.5.14 and PHP with tracing disabled ignore it; native refused it with unsupported_request_field, so a caller that sent it without checking discovery would have its business request refused. Those nine native handlers now drop exactly that field unread. Native never advertises the capability, and other routes, nested fields and unknown fields keep their handling. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
rmcdaniel
enabled auto-merge
October 21, 2026 03:10
12 tasks
…y-carrier # Conflicts: # docs/rust-server-port.md
|
This was referenced Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Part of #325. Native now ignores a caller's optional trace context where PHP Server admits it, so the context can no longer cause a business request to be refused.
Why
PHP Server's optional tracing (#558, Workflow #773) admits a top-level
observability_contexton start, signal, update, cancel and request-cancellation requests when it is enabled. Published PHP 2.5.14 ignores that field, and so does PHP with tracing disabled. Native refused it with 422unsupported_request_field. A caller that sent the field without checking discovery would therefore have its start, signal, update or cancellation refused by native.Change
worker_protocol.server_capabilities.observability_context.Tests
trace_carrierssends each of the nine routes, with and without a carrier, to two identical workflows. It checks four things:The takeover decision for PHP 2.10 databases that have Core 2.9's carrier columns is recorded on #325. It is not part of this change.
🤖 Generated with Claude Code