Fix dstack apply --ssh-identity - #4191
Merged
Merged
Conversation
* Report a proper error instead of a traceback if the key file does not exist or cannot be parsed * Generate the public key from the private key if there is no `.pub` file, as the API docstrings already claimed * Pass the key to `Run.attach()`, so that the run SSH config no longer falls back to `~/.dstack/ssh/id_rsa` * Reject public key paths, as SSH tunneling requires a private key Refactoring and related changes: * Add the `resolve_ssh_key()` helper that resolves a private or public key path to key contents and paths, and reuse it in the fleet configurator, which had the same logic inlined * Look up `<key>.pub` instead of `<key stem>.pub`, which resolved to a wrong path for key names with dots * Add `ssh_key_pub` to `RunCollection.get_run_plan()` and `apply_configuration()` for public keys not stored on disk, mutually exclusive with `ssh_identity_file` * `dstack fleet`: raise `CLIError` instead of printing an error and exiting with a zero exit code Fixes: #4190 Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.pubfile, as the API docstrings already claimedRun.attach(), so that the run SSH config no longer falls back to~/.dstack/ssh/id_rsaRefactoring and related changes:
resolve_ssh_key()helper that resolves a private or public key path to key contents and paths, and reuse it in the fleet configurator, which had the same logic inlined<key>.pubinstead of<key stem>.pub, which resolved to a wrong path for key names with dotsssh_key_pubtoRunCollection.get_run_plan()andapply_configuration()for public keys not stored on disk, mutually exclusive withssh_identity_filedstack fleet: raiseCLIErrorinstead of printing an error and exiting with a zero exit codeFixes: #4190
Co-authored-by: Claude Opus 5 (1M context) noreply@anthropic.com