Add GatewayReplicaModel.name - #4184
Merged
Merged
Conversation
This is a prerequisite to adding gateway replica events, since our event framework requires event targets to be named. The naming pattern is `<gateway-name>-<replica-num>`, consistent with other dstack entities. The new field is backfilled for existing gateways. Restoring the gateway name for deleted gateways is not feasible, so replicas of deleted gateways are backfilled with `unknown-<replica-num>`. No user-facing changes in this commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a prerequisite to adding gateway replica
events, since our event framework requires event
targets to be named.
The naming pattern is
<gateway-name>-<replica-num>, consistent withother dstack entities. The new field is backfilled for existing gateways. Restoring the gateway name
for deleted gateways is not feasible, so replicas
of deleted gateways are backfilled with
unknown-<replica-num>.No user-facing changes in this commit.
#3959